As 2020 wound down, it occurred to us that comments in PR reviews can be universal, if not funny, and sometimes universally funny. Here's a Top 10 (in no particular order) of Chromatic's PR comments from the past year that may sound familiar and may (or may not) tickle the fancy of those of us who build for the web.
-
"...there are a lot of wins in here. I love to see us deleting so many files."
-
"The PR has been through the ringer, but since Mark’s away, we just need the 2nd approval."
-
"@adam Keep in mind, the latest Tugboat build ran like warm butter on toast. It’s good to go."
-
"Approving pending Tugboat testing."
-
"Thanks for the eagle eyes. I made another commit to get rid of that wanton "Forward to friend" link."
-
"With the shared config, I get each new site rocking and rolling and add config files to splits. Clare's yeowoman work here is basically getting config splits used before they were meant to be used."
-
"The drush command to harmonise the UUIDs is in the module so it behooves each site to have it enabled."
Adam responds:"Any PR with behooves in the description is a winner in my book." -
"Assuming failure:
- Revert the commit
- Re-run deployment with reverted commit
- Test that failed site works
- If site still broken, manually import db from backup PROD db step
- Re-run deployment from Jenkins
- Scratch head and figure out what went wrong"
-
"@dependabot rebase"
-
"This is a trust exercise."
